Ported block producer and VRF evaluator #849
Conversation
0xMimir
force-pushed
the
feat/port-block-producer
branch
2 times, most recently
from
718e9ed to
8631a4a
Compare
node/src/block_producer/vrf_evaluator/block_producer_vrf_evaluator_reducer.rs
Outdated
Show resolved
Hide resolved
node/src/block_producer/vrf_evaluator/block_producer_vrf_evaluator_reducer.rs
Outdated
Show resolved
Hide resolved
| self.injected_blocks.remove(best_tip.hash()); | ||
| state.injected_blocks.remove(best_tip.hash()); | ||
| // set the genesis timestamp on the first best tip update | ||
| // TODO: move/remove once we can generate the genesis block |
There was a problem hiding this comment.
@adonagy we do generate the genesis block already, do you remember the context of this comment?
There was a problem hiding this comment.
I assume we can just set this timestamp as soon as the genesis block gets injected right? (maybe we are even doing it already?)
In which case there is no need to wait for the best tip.
node/src/block_producer/vrf_evaluator/block_producer_vrf_evaluator_reducer.rs
Outdated
Show resolved
Hide resolved
tizoc
left a comment
tizoc
left a comment
There was a problem hiding this comment.
LGTM in general, but I need to do another pass. Also lets not merge it before tomorrow's release just in case.
tizoc
left a comment
tizoc
left a comment
There was a problem hiding this comment.
@0xMimir LGTM, please rebase on top of current develop before merging (just to make sure that all commits show up after the v0.11 merge and history doesn't get confusing).
Btw this second pass I did was pretty quick, is there anything I should have paid attention to other than the code moving around and the new callback? (it seems not but just in case)
0xMimir
force-pushed
the
feat/port-block-producer
branch
from
23382ea to
22b7aaa
Compare
2 participants
No description provided.